fix(reader): ensure batch readers return zero-offset Arrow arrays#440
Open
lxy-9602 wants to merge 6 commits into
Open
fix(reader): ensure batch readers return zero-offset Arrow arrays#440lxy-9602 wants to merge 6 commits into
lxy-9602 wants to merge 6 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
BatchReaderresults are transferred through the Arrow C Data Interface and require the returnedarray, including nested child arrays, to have zero offsets.
This change fixes several paths that could return non-zero offsets:
DataEvolutionFileReadercould directly return a sliced singleton array.split by Arrow.
TableBatchReaderaligns mismatched chunk boundaries by slicing columns, which can leavenon-zero offsets in returned columns or nested children.
The change:
BatchReader.DataEvolutionFileReaderconcatenate a singleton array when its offset is non-zero.ArrowUtils::NormalizeRecordBatchOffsetsfor recursively detecting non-zero child offsets.RecordBatchwhen all offsets arezero and only copying columns that require normalization.
Tests
Added the following unit test coverage:
ArrowUtilsTest.TestNormalizeRecordBatchOffsetsArrayDataPageFilteredRowGroupReaderTest.NormalizesSlicedBatchOffsetsAPI and Format
Documentation
Generative AI tooling
Generated-by: OpenAI Codex (GPT-5)